Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): adjust sql mode compatibility for mysql sink #3938

Merged
merged 27 commits into from
Jan 3, 2022
Merged

sink(ticdc): adjust sql mode compatibility for mysql sink #3938

merged 27 commits into from
Jan 3, 2022

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Dec 17, 2021 •
edited
Loading

Signed-off-by: qupeng qupeng@pingcap.com

What problem does this PR solve?

Close #3810.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ben1009
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2021
@hicqu hicqu changed the title adjust sql mode compatibility for mysql sink sink(ticdc): adjust sql mode compatibility for mysql sink Dec 17, 2021
@hicqu hicqu force-pushed the sql-mode-compatible branch 2 times, most recently from 43ab523 to 9dc5f2f Compare December 17, 2021 09:31
@ti-chi-bot
Copy link
Member

@maxshuang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2021
@ben1009
Copy link
Contributor

ben1009 commented Dec 21, 2021

test fail

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2021
@hicqu
Merge branch 'master' into sql-mode-compatible
d6cd925 
Signed-off-by: qupeng <qupeng@pingcap.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021 •
edited
Loading

Codecov Report

Merging #3938 (dd07786) into master (08da001) will increase coverage by 0.1200%.
The diff coverage is 65.0254%.

Flag Coverage Δ
cdc 58.8506% <66.6666%> (+0.2058%) ⬆️
dm 52.2415% <58.1497%> (-0.0131%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #3938        +/-   ##
================================================
+ Coverage   55.1722%   55.2923%   +0.1200%     
================================================
  Files           485        489         +4     
  Lines         59829      60654       +825     
================================================
+ Hits          33009      33537       +528     
- Misses        23484      23731       +247     
- Partials       3336       3386        +50

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 21, 2021
lance6716
lance6716 reviewed Dec 22, 2021
View reviewed changes
cdc/sink/mysql.go Outdated Show resolved Hide resolved
@hicqu hicqu added needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. labels Dec 31, 2021
@overvenus
Copy link
Member

/run-/dm-integration-test

@overvenus
Copy link
Member

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 1df27c6 into pingcap:master Jan 3, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 3, 2022
@hicqu @ti-chi-bot
This is an automated cherry-pick of pingcap#3938
69799bc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 3, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4193.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 3, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4194.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 3, 2022
@hicqu @ti-chi-bot
This is an automated cherry-pick of pingcap#3938
64220e6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 3, 2022
@hicqu @ti-chi-bot
This is an automated cherry-pick of pingcap#3938
6d14a75 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 3, 2022
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4195.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4196.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 3, 2022
@hicqu @ti-chi-bot
This is an automated cherry-pick of pingcap#3938
480be69 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jan 3, 2022
Closed
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4197.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 3, 2022
@hicqu @ti-chi-bot
sink(ticdc): adjust sql mode compatibility for mysql sink (pingcap#3938)
fd0ccc1
ti-chi-bot added a commit that referenced this pull request Jan 4, 2022
@ti-chi-bot
sink(ticdc): adjust sql mode compatibility for mysql sink (#3938) (#4197
1812a71 
)
@hicqu hicqu deleted the sql-mode-compatible branch January 5, 2022 08:20
@hicqu
Copy link
Contributor Author

hicqu commented Jan 5, 2022

/run-cherry-picker

@hicqu hicqu removed needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxshuang maxshuang maxshuang approved these changes

@ben1009 ben1009 ben1009 approved these changes

@lance6716 lance6716 lance6716 approved these changes

@Rustin170506 Rustin170506 Awaiting requested review from Rustin170506

@sdojjy sdojjy Awaiting requested review from sdojjy

Assignees
No one assigned
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session SQL mode causes failures
7 participants
@hicqu @ti-chi-bot @ben1009 @codecov-commenter @maxshuang @lance6716 @overvenus